Skip to content

Prioritize gRPC transport in CreateShellButton#1944

Merged
KCarretto merged 2 commits intomainfrom
update-shell-priority-grpc-15844118393860975175
Feb 27, 2026
Merged

Prioritize gRPC transport in CreateShellButton#1944
KCarretto merged 2 commits intomainfrom
update-shell-priority-grpc-15844118393860975175

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Updated CreateShellButton to prioritize gRPC transport. Added transport field to GraphQL query and implemented sorting logic to prefer gRPC over other transports, while maintaining principal priority as the primary factor. Added unit tests to verify the prioritization logic.


PR created automatically by Jules for task 15844118393860975175 started by @KCarretto

Updates the `CreateShellButton` component to prioritize beacons using gRPC transport when selecting a candidate for a new shell session. The new prioritization order is:
1. High-priority principal (root, Administrator, SYSTEM)
2. gRPC transport
3. Shortest interval
4. Soonest next check-in

This change involves:
- Updating `GET_BEACONS_FOR_HOST_QUERY` to fetch the `transport` field.
- Refactoring `CreateShellButton.tsx` to include `selectBestBeaconId` logic.
- Adding unit tests in `CreateShellButton.test.ts`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2725    ±0 2725    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1368 2725 2725 0 0 0 0 44.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2725 0 0 5.7s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.7s 5.7s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 27, 2026 05:04
@KCarretto KCarretto merged commit 6c48778 into main Feb 27, 2026
8 checks passed
@KCarretto KCarretto deleted the update-shell-priority-grpc-15844118393860975175 branch February 27, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant