Prioritize gRPC transport in CreateShellButton#1944
Conversation
Updates the `CreateShellButton` component to prioritize beacons using gRPC transport when selecting a candidate for a new shell session. The new prioritization order is: 1. High-priority principal (root, Administrator, SYSTEM) 2. gRPC transport 3. Shortest interval 4. Soonest next check-in This change involves: - Updating `GET_BEACONS_FOR_HOST_QUERY` to fetch the `transport` field. - Refactoring `CreateShellButton.tsx` to include `selectBestBeaconId` logic. - Adding unit tests in `CreateShellButton.test.ts`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
Updated
CreateShellButtonto prioritize gRPC transport. Addedtransportfield to GraphQL query and implemented sorting logic to prefer gRPC over other transports, while maintaining principal priority as the primary factor. Added unit tests to verify the prioritization logic.PR created automatically by Jules for task 15844118393860975175 started by @KCarretto