Skip to content

Fix ShellV2 active users query validation error #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 3 commits into from
Feb 27, 2026
Merged

Fix ShellV2 active users query validation error #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41107b1
Fix GET_SHELL_ACTIVE_USERS query and data handling for Relay connection
google-labs-jules[bot] Feb 27, 2026
f162d58
Merge branch 'main' into fix-shellv2-active-users-query-3744604748372…
KCarretto Feb 27, 2026
dd925ae
rebuild ui
KCarretto Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tavern/internal/www/build/asset-manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tavern/internal/www/build/index.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...rnal/www/build/static/js/main.35b36bb4.js → ...rnal/www/build/static/js/main.f7c2b632.js
View file
Open in desktop

Large diffs are not rendered by default.

0 ...ld/static/js/main.35b36bb4.js.LICENSE.txt → ...ld/static/js/main.f7c2b632.js.LICENSE.txt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../www/build/static/js/main.35b36bb4.js.map → .../www/build/static/js/main.f7c2b632.js.map
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions tavern/internal/www/src/pages/shellv2/graphql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ export const GET_SHELL_ACTIVE_USERS = gql`
node(id: $id) {
... on Shell {
activeUsers {
id
name
edges {
node {
id
name
}
}
}
}
}
Expand Down
4 changes: 3 additions & 1 deletion tavern/internal/www/src/pages/shellv2/hooks/useShellData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ export const useShellData = (shellId: string | undefined) => {
}
}, [portalData]);

const activeUsers = activeUsersData?.node?.activeUsers?.edges?.map((edge: any) => edge.node) || [];

return {
loading,
error,
Expand All @@ -59,6 +61,6 @@ export const useShellData = (shellId: string | undefined) => {
portalData,
portalId,
setPortalId,
activeUsers: activeUsersData?.node?.activeUsers || []
activeUsers
};
};
Loading