Update ShellV2 status bar connection text#1952
Conversation
…tate. This change updates the tooltips in the ShellV2 status bar to explicitly state "Connected to Tavern", "Reconnecting to Tavern", and "Disconnected from Tavern". Additionally, it propagates the WebSocket close reason from the adapter to the UI, allowing the disconnected tooltip to display specific error messages if available (e.g., "Disconnected from Tavern: Connection lost"). Changes: - Modified `HeadlessWasmAdapter.ts` to capture `CloseEvent.reason` and pass it to the `onStatusChange` callback. - Updated `useShellTerminal.ts` to store `connectionMessage` state and expose it. - Updated `ShellStatusBar.tsx` to accept `connectionMessage` and update tooltips. - Updated `ShellStatusBar.test.tsx` to reflect prop changes and added a test case for the disconnection reason. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
KCarretto
deleted the
shellv2-connection-status-text-6454658352223313857
branch
1 participant
Updates the ShellV2 status bar to provide clearer connection status messages, including specific disconnection reasons propagated from the WebSocket close event.
PR created automatically by Jules for task 6454658352223313857 started by @KCarretto