feat(shellv2): add tooltips to shell header beacon and host names#1954
feat(shellv2): add tooltips to shell header beacon and host names#1954
Conversation
- Update `GET_SHELL` query in `graphql.ts` to include `principal`, `agentIdentifier`, `interval`, `transport` for the beacon, and `primaryIP`, `externalIP`, `platform` for the host. - Update `ShellHeader.tsx` to display these details in tooltips when hovering over the beacon name and host name. - Use `getEnumKey` to format `transport` and `platform` values. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
- Fix `database table is locked` errors in `TestNonInteractiveShell` and others by setting `SetMaxOpenConns(1)` for the SQLite test database and increasing `_busy_timeout`. - Fix infinite hangs in tests by adding `ws.SetReadDeadline` to websocket reads. - Fix assertion error in `TestOtherStreamOutput_Polling` to match the backend's ANSI color output format (purple/green). - Replace `enttest.Open` with manual `sql.Open` + `ent.NewClient` to allow configuring connection limits. - Add missing `ent/runtime` import to ensure default hooks are registered. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
1 participant
This PR updates the ShellV2 header to provide more context about the active shell.
It adds tooltips to the beacon name and host name, displaying key information such as the principal, agent identifier, interval, transport, primary IP, external IP, and platform.
The GraphQL query for fetching shell data has been updated to request these additional fields.
PR created automatically by Jules for task 722756142593178065 started by @KCarretto