fix: associate ShellPivot with Shell via query param#2206
Conversation
When establishing a new SSH portal via websocket, the ShellPivot ent was created without an associated ShellID. This prevented the frontend from reopening the shell tab when reloading the page. This commit updates the frontend to pass the `shell_id` as a query parameter when establishing the connection, and updates the backend to extract the query param and use `SetShellID` when creating the ShellPivot. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
When establishing a new SSH portal via websocket, the ShellPivot ent was created without an associated ShellID. This prevented the frontend from reopening the shell tab when reloading the page.
This commit updates the frontend to pass the
shell_idas a query parameter when establishing the connection, and updates the backend to extract the query param and useSetShellIDwhen creating the ShellPivot.PR created automatically by Jules for task 13938958894000212529 started by @KCarretto