Skip to content

Add Notification Bell to Sidebar#2210

Draft
KCarretto wants to merge 1 commit intomainfrom
feat/notification-bell-10556183947555506364
Draft

Add Notification Bell to Sidebar#2210
KCarretto wants to merge 1 commit intomainfrom
feat/notification-bell-10556183947555506364

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

I have added a new notification bell feature to the sidebar of the Tavern web interface.

Key Changes:

  • NotificationBell Component: A new component that displays a bell icon with a purple badge indicating the number of unread notifications.
  • Categorized Popover: Clicking the bell opens a popover with tabs for Urgent, Unread, Read, and Archived notifications. Tabs are only displayed if they contain notifications.
  • Timeline Visualization: Notifications are displayed in a timeline format with connecting lines and icons corresponding to the event type (e.g., bug icon for host-related events).
  • Automatic Mark-as-Read: Unread notifications in the active tab are automatically marked as read when the popover is opened or a tab is switched.
  • Sidebar Integration: The bell is placed in-line with the profile in the expanded sidebar and above the profile in the minimized sidebar.
  • GraphQL Integration: Added the necessary GraphQL queries and mutations to fetch and update notification states.

The implementation uses Chakra UI for the popover and tabs, and follows the existing styling patterns in the project. Unit tests were run to ensure no regressions were introduced.


PR created automatically by Jules for task 10556183947555506364 started by @KCarretto

- implement NotificationBell component with unread badge and popover
- add categorized tabs (Urgent, Unread, Read, Archived) with automatic mark-as-read
- include timeline visualization for notifications
- integrate bell into expanded and minimized sidebars
- update GraphQL queries and types for notifications

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2945 2944 1 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2037 2945 2944 1 0 0 0 493347h

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2945 0 1 10m 54s

Fail Rate

Fail Rate 0.03%
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
TestMetrics_QuestTimelineChart 1 0 1 100.00    ↑100.00

Failed Tests

Failed Tests
❌ TestMetrics_QuestTimelineChart
=== RUN   TestMetrics_QuestTimelineChart
    metrics_test.go:101: 
        	Error Trace:	/home/runner/work/realm/realm/tavern/internal/graphql/metrics_test.go:101
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestMetrics_QuestTimelineChart
--- FAIL: TestMetrics_QuestTimelineChart (0.01s)

Trace:

No trace available

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 5m 53s 10m 54s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 5m 53s 10m 54s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 5m 53s 10m 54s
TestDockerExecutor_Build_StreamsOutputInRealTime 1 6.1s 6.1s
TestDockerExecutor_Build_ContextCancellation 1 6.0s 6.0s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant