add unique name selection and opportunistically generate lower comple…#402
add unique name selection and opportunistically generate lower comple…#402KCarretto merged 16 commits intospellshift:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 66.58% 71.29% +4.71%
==========================================
Files 116 116
Lines 8325 8956 +631
==========================================
+ Hits 5543 6385 +842
+ Misses 2670 2453 -217
- Partials 112 118 +6 ☔ View full report in Codecov by Sentry. |
|
do i need to write a test for Beaconnameinstring() and the different complexity levels? |
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Few nits if you feel inclined.
KCarretto
left a comment
KCarretto
left a comment
There was a problem hiding this comment.
Primary feedback is to separate API into 3 namegen methods, as that would improve readability quite a bit. Additionally, it appears you're indexing adjectives and nouns when you should be accessing the Halloween variants, which can cause index out of range errors. By swapping to the newAdjective and newNoun helper methods (I demonstrated above), this should hopefully be a bit less confusing to internal package callers. It will also make it significantly easier to add more thematic support in the future.
Otherwise, looks good, thanks for all the work on this!
|
was this fixed in PR #435 ? |
add unique name selection and opportunistically generate lower comple… (#402) * add unique name selection and opportunistically generate lower complexity names * fix tests * batch search for collisions. and add a complexity identifier * add test for Beaconnameinstring * add tests to other random names * add requested changes. * make duplicate test use complex names * impliment one retry per request to generate a name * rename the complexity levels * seperate them out into diffrent functions, removing the enum * fix imports * add ent to namegen test --------- Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com> Co-authored-by: KCarretto <Kcarretto@gmail.com>
3 participants
adds unique name selection and opportunistically generate lower complexity beacon names