Skip to content

adding file tree tome and update bad reference in docs#438

Merged
adm1nPanda merged 3 commits intomainfrom
file_tree_tome
Jan 16, 2024
Merged

adding file tree tome and update bad reference in docs#438
adm1nPanda merged 3 commits intomainfrom
file_tree_tome

Conversation

@adm1nPanda
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/feature
/kind tomes

What this PR does / why we need it:

Adding file tree tome

Which issue(s) this PR fixes:

Fixes #422

@adm1nPanda adm1nPanda requested a review from hulto January 16, 2024 03:05
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c099f3) 73.47% compared to head (86a8a17) 71.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   73.47%   71.46%   -2.02%     
==========================================
  Files          85      115      +30     
  Lines        7006     8835    +1829     
==========================================
+ Hits         5148     6314    +1166     
- Misses       1858     2412     +554     
- Partials        0      109     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hulto
hulto previously approved these changes Jan 16, 2024
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding links LGTM

@adm1nPanda adm1nPanda merged commit 6c77394 into main Jan 16, 2024
@adm1nPanda adm1nPanda deleted the file_tree_tome branch January 16, 2024 22:20
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
adding file tree tome and update bad reference in docs (#438)

* adding file tree tome and update bad reference in docs

* including links in tree and fix missing type for links in file_list tome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a file tree tome.

2 participants