[feature] Added hook to track task output size#442
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 71.46% 71.43% -0.03%
==========================================
Files 115 115
Lines 8835 8865 +30
==========================================
+ Hits 6314 6333 +19
- Misses 2412 2422 +10
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
cmp5987
approved these changes
Jan 21, 2024
Collaborator
Author
It will be available on all tasks (automatically derived) 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new field to
Task,"output_size", which stores the size of the task's output. It adds a new schema hook to maintain this value any time tasks are updated with new output. This will effectively serve as a "has_output" check as well by filtering for tasks with size > 0. Ideally this implementation would also allow API callers to filter out large task outputs etc. if desired.Which issue(s) this PR fixes:
Fixes #427