Skip to content

created the manual client for tavern so we can change callback url#457

Merged
Cictrone merged 4 commits intomainfrom
tonic-url
Jan 22, 2024
Merged

created the manual client for tavern so we can change callback url#457
Cictrone merged 4 commits intomainfrom
tonic-url

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

So we have some control over callback URL.

@Cictrone Cictrone requested review from KCarretto and hulto January 21, 2024 23:12
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (e59b69b) 71.46% compared to head (4df4924) 71.01%.
Report is 6 commits behind head on main.

Files Patch % Lines
implants/lib/c2/src/c2_manual.rs 0.00% 68 Missing ⚠️
implants/imix/src/tasks.rs 0.00% 3 Missing ⚠️
implants/imix/src/main.rs 0.00% 2 Missing ⚠️
tavern/app.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   71.46%   71.01%   -0.45%     
==========================================
  Files         118      119       +1     
  Lines        9003     9081      +78     
==========================================
+ Hits         6434     6449      +15     
- Misses       2446     2509      +63     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KCarretto
KCarretto previously approved these changes Jan 22, 2024
@Cictrone Cictrone merged commit 1bad2d7 into main Jan 22, 2024
@Cictrone Cictrone deleted the tonic-url branch January 22, 2024 01:20
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
created the manual client for tavern so we can change callback url (#457)

* created the manual client for tavern so we can change callback url

* undoing needless change

* kyle fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants