Skip to content

fixed all the problems#458

Merged
Cictrone merged 2 commits intomainfrom
low-hanging-fruit
Jan 22, 2024
Merged

fixed all the problems#458
Cictrone merged 2 commits intomainfrom
low-hanging-fruit

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

NO MORE PROBLEMS

@Cictrone Cictrone requested a review from hulto January 22, 2024 03:01
@hulto
Copy link
Copy Markdown
Collaborator

hulto commented Jan 22, 2024

This seems like a bad way to solve the problem..... 😭

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bad2d7) 71.29% compared to head (70aece6) 71.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   71.29%   71.32%   +0.03%     
==========================================
  Files         119      119              
  Lines        9368     9379      +11     
==========================================
+ Hits         6679     6690      +11     
  Misses       2566     2566              
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Cictrone Cictrone merged commit 1a40a20 into main Jan 22, 2024
@Cictrone Cictrone deleted the low-hanging-fruit branch January 22, 2024 03:22
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
fixed all the problems (#458)

* fixed all the problems

* do the allow unused instead of _
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants