Skip to content

Documentation typo/spelling corrections#506

Merged
hulto merged 4 commits intospellshift:mainfrom
Alextibtab:documentation-typos
Jan 26, 2024
Merged

Documentation typo/spelling corrections#506
hulto merged 4 commits intospellshift:mainfrom
Alextibtab:documentation-typos

Conversation

@Alextibtab
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  • Updated tavern documentation for creating quests
  • Tweaked some grammar
  • Corrected some spelling mistakes/typos.

Which issue(s) this PR fixes:

NA

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7c44dc) 70.91% compared to head (962d376) 70.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         126      126           
  Lines       10001    10001           
=======================================
  Hits         7092     7092           
  Misses       2764     2764           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hulto
hulto previously approved these changes Jan 26, 2024
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock for doing this TYVM!
One change but otherwise LGTM 🫡

- Beacons - What you'll be executing on
- Tomes - What you'll be executing
- Input parametrs - arguments passed to the tome and eldritch interperet as `input_params{}`
- Input parameters - arguments passed to the tome and eldritch interpret as `input_params{}`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap interpret to interpreter

Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hulto hulto merged commit ab8ed36 into spellshift:main Jan 26, 2024
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Documentation typo/spelling corrections (#506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants