Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 70.88% 70.78% -0.10%
==========================================
Files 141 141
Lines 10225 10184 -41
==========================================
- Hits 7248 7209 -39
+ Misses 2811 2809 -2
Partials 166 166 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates
eldritch::Runtimeto manage it's own thread, since callers were being forced to call it in a separate thread anyways. Now we support aneldritch::startAPI for running tomes in a separate thread, which returns aRuntime. TheBrokerhas been removed, and nowRuntimeis the callers interface to interact with the running eldritch thread. We have also renamed theeldritch::Clienttoeldritch::Environment, which is still intended to be used by eldritch functions to interface with the caller (request files, report processes, etc.)Example Usage