[cleanup] Refactor Eldritch Library Registration#579
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 71.28% 71.83% +0.54%
==========================================
Files 141 142 +1
Lines 10092 9955 -137
==========================================
- Hits 7194 7151 -43
+ Misses 2732 2638 -94
Partials 166 166 ☔ View full report in Codecov by Sentry. |
hulto
requested changes
Feb 12, 2024
docs/_docs/dev-guide/eldritch.md
Outdated
| ``` | ||
|
|
||
| ### Async PR example | ||
| #### Async PR example |
Collaborator
There was a problem hiding this comment.
We should probably remove this too since it's no longer a good reference.
nullmonk
pushed a commit
that referenced
this pull request
Feb 14, 2024
* added eldritch_lib macro, moved to mod.rs * updated docs * fix nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
eldritch_lib!()macro for defining librariesif false)mod.rsto cleanup the eldritch root directory