Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 70.97% 71.76% +0.78%
==========================================
Files 161 175 +14
Lines 10776 12111 +1335
==========================================
+ Hits 7648 8691 +1043
- Misses 2949 3205 +256
- Partials 179 215 +36 ☔ View full report in Codecov by Sentry. |
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Couple thoughts then it should be good to go
| if isinstance(depth, str) and not depth.lstrip("-").isdigit(): | ||
| print("ERROR: Invalid depth specified, must be a valid number") | ||
| return | ||
| depth=int(depth) |
There was a problem hiding this comment.
This seem redundant with the above
There was a problem hiding this comment.
What do you mean redundant? -1 is not handled properly by the is digit function. This also gracefully exits rather than just crashing
| windows = sys.is_windows() | ||
|
|
||
| def file_list(path,tree): | ||
| def can_read(f): |
There was a problem hiding this comment.
Instead of adding can_read lets make file.list fail in a recoverable way similar to the new file.find function
There was a problem hiding this comment.
We'll move forward with it as is and then remove the can_read here once the eldritch change has been made.
3 participants
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
Add permissions check to the file tree tome so it does not crash when encountering an unreadable directory