Skip to content

[bug] Fix Credential Kind Enum#597

Merged
KCarretto merged 2 commits intomainfrom
fix-creds-enum
Feb 14, 2024
Merged

[bug] Fix Credential Kind Enum#597
KCarretto merged 2 commits intomainfrom
fix-creds-enum

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the credential enum (was accidentally using copy+pasta'd process value map)

@KCarretto KCarretto requested review from Cictrone and hulto February 14, 2024 04:28
Cictrone
Cictrone previously approved these changes Feb 14, 2024
Copy link
Copy Markdown
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheeky

hulto
hulto previously approved these changes Feb 14, 2024
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KCarretto KCarretto dismissed stale reviews from hulto and Cictrone via 776c838 February 14, 2024 04:32
@KCarretto KCarretto merged commit f0ae9e2 into main Feb 14, 2024
@KCarretto KCarretto deleted the fix-creds-enum branch February 14, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants