Skip to content

Regex-lib-stub#601

Merged
Cictrone merged 6 commits intomainfrom
regex-lib-stub
Feb 16, 2024
Merged

Regex-lib-stub#601
Cictrone merged 6 commits intomainfrom
regex-lib-stub

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-library

What this PR does / why we need it:

for our string-oriented fiends

Which issue(s) this PR fixes:

Fixes QoL

@Cictrone Cictrone assigned Cictrone, hulto and KCarretto and unassigned Cictrone Feb 16, 2024
hulto
hulto previously approved these changes Feb 16, 2024
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype

hulto
hulto previously approved these changes Feb 16, 2024
`file.replace(path: str, pattern: str, value: str) -> None`
The <b>file.replace</b> method is very cool, and will be even cooler when Nick documents it.

Unimplemented.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to escape responsibility I see

KCarretto
KCarretto previously approved these changes Feb 16, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1cad69f) 70.97% compared to head (11c1325) 70.95%.

Files Patch % Lines
implants/lib/eldritch/src/regex/match_all_impl.rs 0.00% 2 Missing ⚠️
implants/lib/eldritch/src/regex/match_impl.rs 0.00% 2 Missing ⚠️
...mplants/lib/eldritch/src/regex/replace_all_impl.rs 0.00% 2 Missing ⚠️
implants/lib/eldritch/src/regex/replace_impl.rs 0.00% 2 Missing ⚠️
implants/lib/eldritch/src/regex/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   70.97%   70.95%   -0.02%     
==========================================
  Files         161      166       +5     
  Lines       10776    10801      +25     
==========================================
+ Hits         7648     7664      +16     
- Misses       2949     2958       +9     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cictrone Cictrone dismissed stale reviews from KCarretto and hulto via 3619ad2 February 16, 2024 21:07
@Cictrone Cictrone merged commit dc6806b into main Feb 16, 2024
@Cictrone Cictrone deleted the regex-lib-stub branch February 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants