Skip to content

RegexLibrary Implementation#602

Merged
Cictrone merged 3 commits intomainfrom
regex-impl
Feb 17, 2024
Merged

RegexLibrary Implementation#602
Cictrone merged 3 commits intomainfrom
regex-impl

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

For the regex!

Which issue(s) this PR fixes:

Fixes broken hearts

@Cictrone Cictrone requested review from KCarretto and hulto February 16, 2024 22:52
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc6806b) 70.95% compared to head (65db1e8) 71.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   70.95%   71.55%   +0.59%     
==========================================
  Files         166      166              
  Lines       10801    10999     +198     
==========================================
+ Hits         7664     7870     +206     
+ Misses       2958     2950       -8     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cictrone Cictrone merged commit e2e9a57 into main Feb 17, 2024
@Cictrone Cictrone deleted the regex-impl branch February 17, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants