Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 67.84% 71.53% +3.69%
==========================================
Files 167 167
Lines 10420 11002 +582
==========================================
+ Hits 7069 7870 +801
+ Misses 3172 2953 -219
Partials 179 179 ☔ View full report in Codecov by Sentry. |
KCarretto
reviewed
Feb 17, 2024
| create_res = sys.shell("sc.exe create "+service_name+" binpath= "+executable_path+" displayname="+service_display_name+" start= auto type= own") | ||
| if 'ERROR' in create_res['stdout'] or create_res['stderr'] != "": | ||
| print("Failed to create service:\n") | ||
| print(create_res) |
Collaborator
There was a problem hiding this comment.
nit: combine these into one print statement
print("failed to create service:\n"+create_rest+"\n")
KCarretto
reviewed
Feb 17, 2024
| extern crate windows_service; | ||
|
|
||
| use imix::handle_main; | ||
| use imix::{handle_main}; |
KCarretto
previously approved these changes
Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a default way for imix users to install on windows.
Fix imix service build allowing it to run as a regular exe as well.