Skip to content

[feature] Paginate Quests#619

Merged
cmp5987 merged 8 commits intomainfrom
quest-pagination
Feb 26, 2024
Merged

[feature] Paginate Quests#619
cmp5987 merged 8 commits intomainfrom
quest-pagination

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds pagination to Quest GraphQL Root Query

@KCarretto KCarretto requested a review from cmp5987 February 18, 2024 21:27
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.76%. Comparing base (e6a8a28) to head (18cc3c1).

Files Patch % Lines
tavern/internal/ent/schema/quest.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   71.71%   71.76%   +0.04%     
==========================================
  Files         175      175              
  Lines       12086    12111      +25     
==========================================
+ Hits         8668     8691      +23     
- Misses       3203     3205       +2     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cictrone
Cictrone previously approved these changes Feb 19, 2024
@cmp5987
Copy link
Copy Markdown
Collaborator

cmp5987 commented Feb 26, 2024

Updated UI to get data from the nested 'edges' and 'node'.

cmp5987
cmp5987 previously approved these changes Feb 26, 2024
Copy link
Copy Markdown
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added UI support to avoid breaking changes

@cmp5987 cmp5987 merged commit b25fd49 into main Feb 26, 2024
@cmp5987 cmp5987 deleted the quest-pagination branch February 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants