Skip to content

Make http.get and http.post ignore TLS validation and be less async#649

Merged
KCarretto merged 2 commits intomainfrom
be-less-secure-http
Feb 21, 2024
Merged

Make http.get and http.post ignore TLS validation and be less async#649
KCarretto merged 2 commits intomainfrom
be-less-secure-http

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Because TLS is never REAL.

@Cictrone Cictrone requested review from KCarretto and hulto February 21, 2024 15:37
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2868dbc) 72.06% compared to head (b044ca0) 72.00%.

Files Patch % Lines
implants/lib/eldritch/src/http/post_impl.rs 76.31% 9 Missing ⚠️
implants/lib/eldritch/src/http/get_impl.rs 88.23% 2 Missing ⚠️
implants/lib/eldritch/src/http/download_impl.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   72.06%   72.00%   -0.07%     
==========================================
  Files         174      174              
  Lines       11964    11977      +13     
==========================================
+ Hits         8622     8624       +2     
- Misses       3128     3139      +11     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit 383628c into main Feb 21, 2024
@KCarretto KCarretto deleted the be-less-secure-http branch February 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants