Skip to content

Fix lint warn.#663

Closed
hulto wants to merge 1 commit intomainfrom
cleanup
Closed

Fix lint warn.#663
hulto wants to merge 1 commit intomainfrom
cleanup

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Feb 24, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.02%. Comparing base (e2cdb47) to head (595cafa).

Files Patch % Lines
implants/lib/eldritch/src/sys/get_ip_impl.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         175      175           
  Lines       12008    12008           
=======================================
  Hits         8649     8649           
  Misses       3145     3145           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

},
None => {
ips.push(ip.ip().to_string())
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im afraid at the lack of comma... but it compiles :o

@hulto
Copy link
Copy Markdown
Collaborator Author

hulto commented Feb 25, 2024

Duped by #665

@hulto hulto closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants