Skip to content

Added a file.mkdir tome and also added a parent param similar to linux's #666

Merged
Cictrone merged 3 commits intomainfrom
raynes-feature
Feb 25, 2024
Merged

Added a file.mkdir tome and also added a parent param similar to linux's #666
Cictrone merged 3 commits intomainfrom
raynes-feature

Conversation

@Cictrone
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Rayne NEEDS this

@Cictrone Cictrone requested review from KCarretto and hulto February 25, 2024 20:04
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.06%. Comparing base (9a22eb0) to head (ab3fed8).

Files Patch % Lines
implants/lib/eldritch/src/file/mkdir_impl.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   72.02%   72.06%   +0.03%     
==========================================
  Files         175      175              
  Lines       11998    12017      +19     
==========================================
+ Hits         8642     8660      +18     
- Misses       3142     3143       +1     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rayne I hope your dir adventures are fruitful

@Cictrone Cictrone merged commit 1751355 into main Feb 25, 2024
@Cictrone Cictrone deleted the raynes-feature branch February 25, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants