Skip to content

fix(button): Add default button to replace chakra button#714

Merged
cmp5987 merged 2 commits intomainfrom
cp-remove-chakra-buttons
Mar 16, 2024
Merged

fix(button): Add default button to replace chakra button#714
cmp5987 merged 2 commits intomainfrom
cp-remove-chakra-buttons

Conversation

@cmp5987
Copy link
Copy Markdown
Collaborator

@cmp5987 cmp5987 commented Mar 16, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Replaces Chakra UI buttons and html buttons with a Tavern specific UI Button

@cmp5987 cmp5987 requested review from KCarretto and hulto March 16, 2024 02:37
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.25%. Comparing base (0830f10) to head (974d6b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   72.48%   69.25%   -3.23%     
==========================================
  Files         122      179      +57     
  Lines        9110    12778    +3668     
==========================================
+ Hits         6603     8850    +2247     
- Misses       2507     3701    +1194     
- Partials        0      227     +227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit 031684a into main Mar 16, 2024
@cmp5987 cmp5987 deleted the cp-remove-chakra-buttons branch March 16, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants