Skip to content

Binary read support#740

Merged
hulto merged 11 commits intomainfrom
file-replace-support-utf-eight
Apr 6, 2024
Merged

Binary read support#740
hulto merged 11 commits intomainfrom
file-replace-support-utf-eight

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Mar 29, 2024

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

This PR adds support for reading binary files and adds remote support to the remaining asset functions:

  • read
  • read_binary
  • list

Which issue(s) this PR fixes:

Fixes #725

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 98.02260% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 69.94%. Comparing base (ee968bb) to head (c0679a9).

Files Patch % Lines
implants/lib/eldritch/src/assets/list_impl.rs 94.64% 3 Missing ⚠️
...plants/lib/eldritch/src/assets/read_binary_impl.rs 97.27% 3 Missing ⚠️
implants/lib/eldritch/src/assets/read_impl.rs 99.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   69.24%   69.94%   +0.70%     
==========================================
  Files         179      179              
  Lines       12745    13060     +315     
==========================================
+ Hits         8825     9135     +310     
- Misses       3693     3698       +5     
  Partials      227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cictrone
Cictrone previously approved these changes Mar 31, 2024
Copy link
Copy Markdown
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pls make sure there are no lints

Comment thread implants/lib/eldritch/src/assets/read_binary_impl.rs Outdated
Comment thread implants/lib/eldritch/src/assets/read_binary_impl.rs Outdated
Comment thread implants/lib/eldritch/src/assets/read_binary_impl.rs
Comment thread implants/lib/eldritch/src/assets/read_impl.rs Outdated
Comment thread implants/lib/eldritch/src/file/template_impl.rs
@hulto
Copy link
Copy Markdown
Collaborator Author

hulto commented Apr 5, 2024

No lints
image

Copy link
Copy Markdown
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

@hulto hulto merged commit 7fff59c into main Apr 6, 2024
@hulto hulto deleted the file-replace-support-utf-eight branch April 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] None of the assets functions except assets.copy() implement the remote API

2 participants