User Management Page by jabbate19 · Pull Request #771 · spellshift/realm

jabbate19 · 2024-05-05T22:53:57Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a User Management page. Instead of needing to use the GraphQL Playground, you can approve/promote users in the website.

Which issue(s) this PR fixes:

N/A

jabbate19 · 2024-05-05T23:01:34Z

cmp5987

Just a few comments based on what you currently have written.

tavern/internal/www/src/components/page-wrapper/PageWrapper.tsx

tavern/internal/www/src/pages/user-list/components/UserTable.tsx

tavern/internal/www/src/pages/user-list/hooks/useUserTable.ts

tavern/internal/www/src/utils/enums.ts

tavern/internal/www/src/pages/user-list/components/UserTable.tsx

jabbate19 · 2024-12-28T23:52:50Z

Updated photos

Admin UI

If a user attempts to access /admin while not admin

Non-Admin Users still do not see Admin in navbar

tavern/internal/www/src/components/page-wrapper/PageWrapper.tsx

cmp5987 · 2025-01-09T03:02:51Z

tavern/internal/www/src/components/page-wrapper/PageWrapper.tsx

  const [sidebarOpen, setSidebarOpen] = useState(false)
+  const {data, isLoading, error} = useContext(AuthorizationContext);
+
+  if(isLoading){


I think it would be good to pull this logic outside of PageWrapper so the PageWrapper is only accessed after AuthorizationContext is loaded.

I kept this here because it needs to be used by AccessGate and Navigation. Is there an easy way to use it in both places without using context twice?

cmp5987 · 2025-01-09T03:21:07Z

tavern/internal/www/src/pages/admin/hooks/userMutations.ts

+        }
+    `;
+
+    const handleError = (error: NetworkError | GraphQLErrors) => {


When are these errors displayed, I saw the submit used by the table.

Additionally, How are they reset to false for if a user tries to re-trigger the action on a failure?

Wdym by this?

When an error occurs as a result of a user demoting/promoting a user. We should be displaying these errors to the user. This could occur via Toast or other banner message. It should also be dismissible.

cmp5987 · 2025-01-25T01:31:23Z

tavern/internal/www/src/pages/admin/AdminPortal.tsx

+                    <span>This portal is for managing users allowed to access Tavern. You can also promote users to Administrator, who will be able to access this page.</span>
+                </div>
+            </div>
+            <Tab.Group>


Any plans for what this will expand to include, right now we have only 1 tab so its a bit odd to include a tab/tab panel.

Since we are naming it an "Admin" panel, thought it would be good to add tabs if other admin features need to get added later

tavern/internal/www/src/pages/admin/components/UserTable.tsx

tavern/internal/www/src/pages/admin/AdminPortal.tsx

jabbate19 · 2025-01-25T23:12:51Z

New red button styles

Fixed text location

jabbate19 · 2025-01-25T23:20:36Z

Without tabs

jabbate19 · 2025-01-26T03:13:32Z

Solves #838

KCarretto · 2025-01-26T16:41:04Z

Will leave this review to @cmp5987 as well

cmp5987 · 2025-01-27T01:47:34Z

Nits:

Mind adding 'buttonVariant="ghost" to the action buttons.
Add feedback handling for success or error cases when users click 'actions. Think Toast or Inline banners that are dismissible.
Don't forget to squash before merging but this looks almost ready.
Add loading states to buttons and prevent interaction when a user's action is being processed. In scenarios where backend is slow we don't really want to have things double clicked or users to not understand that their action is getting processed.

Task Output vs Task Finished
I think the task output vs task finished really depends. The ideal for the statistic would be tasks with meaningful information available. Unfortunately, 'finished' doesn't mean success/not failed. Output can also be filled with errors depending on the task V_V. Let's stick with whichever you prefer and iterate based on 2025 ISTS feedback.

jabbate19 · 2025-01-27T02:00:34Z

Add feedback handling for success or error cases when users click 'actions. Think Toast or Inline banners that are dismissible.

Is there an example in the codebase I can use?

jabbate19 · 2025-01-27T02:23:02Z

Mind adding 'buttonVariant="ghost" to the action buttons.

Your call, but imo I think this looks off unless we add a background color to the button or outline

cmp5987 · 2025-01-27T04:09:08Z

Add feedback handling for success or error cases when users click 'actions. Think Toast or Inline banners that are dismissible.

Is there an example in the codebase I can use?

For an Inline banner example we have 'AlertError' component that was used in our Tome repo setup.
https://github.com/spellshift/realm/blob/main/tavern/internal/www/src/pages/tomes/components/StepCreateRepository.tsx#L32

This is a simple guide on using Chakra-UI Toasts for user feedback.
https://medium.com/@santhoshs19032003/easy-toast-messages-in-react-with-chakra-ui-a-beginners-guide-8833807d9e12

jabbate19 · 2025-01-31T12:33:27Z

Changed button to outline, imo looks better with the outline contract than white on white
Added toasts

cmp5987

Awesome work,
Don't forget to squash, rebase and rebuild the UI.

~ I think we can squeeze this in for next weeks release.

jabbate19 requested a review from cmp5987 May 5, 2024 23:10

cmp5987 reviewed May 6, 2024

View reviewed changes

jabbate19 force-pushed the users branch from 11dee52 to af7130c Compare December 28, 2024 18:59

jabbate19 requested a review from cmp5987 December 29, 2024 00:27

cmp5987 reviewed Jan 9, 2025

View reviewed changes

tavern/internal/www/src/components/page-wrapper/PageWrapper.tsx Outdated Show resolved Hide resolved

cmp5987 reviewed Jan 9, 2025

View reviewed changes

cmp5987 reviewed Jan 25, 2025

View reviewed changes

tavern/internal/www/src/pages/admin/components/UserTable.tsx Outdated Show resolved Hide resolved

cmp5987 reviewed Jan 25, 2025

View reviewed changes

tavern/internal/www/src/pages/admin/AdminPortal.tsx Outdated Show resolved Hide resolved

jabbate19 requested a review from cmp5987 January 25, 2025 23:24

jabbate19 force-pushed the users branch from 328cd5d to ff77039 Compare January 26, 2025 03:00

KCarretto assigned cmp5987 Jan 26, 2025

jabbate19 added this to the v0.2.0 milestone Jan 26, 2025

cmp5987 previously approved these changes Feb 1, 2025

View reviewed changes

jabbate19 dismissed cmp5987’s stale review via bd6cf0f February 1, 2025 21:53

jabbate19 force-pushed the users branch from bd6cf0f to be49b28 Compare February 1, 2025 22:03

jabbate19 requested a review from cmp5987 February 1, 2025 22:06

jabbate19 force-pushed the users branch from be49b28 to f4c55d0 Compare February 1, 2025 22:08

Add User Management (Admin) Page

95ac440

jabbate19 force-pushed the users branch from f4c55d0 to 95ac440 Compare February 1, 2025 22:10

KCarretto merged commit 12a3bf4 into main Feb 1, 2025

KCarretto deleted the users branch February 1, 2025 22:28

Conversation

jabbate19 commented May 5, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Uh oh!

jabbate19 commented May 5, 2024

Uh oh!

cmp5987 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jabbate19 commented Dec 28, 2024

Uh oh!

Uh oh!

cmp5987 Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

jabbate19 Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

cmp5987 Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

jabbate19 Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

cmp5987 Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

cmp5987 Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

jabbate19 Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jabbate19 commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jabbate19 commented Jan 25, 2025

Uh oh!

jabbate19 commented Jan 26, 2025

Uh oh!

KCarretto commented Jan 26, 2025

Uh oh!

cmp5987 commented Jan 27, 2025

Uh oh!

jabbate19 commented Jan 27, 2025

Uh oh!

jabbate19 commented Jan 27, 2025

Uh oh!

cmp5987 commented Jan 27, 2025

Uh oh!

jabbate19 commented Jan 31, 2025

Uh oh!

cmp5987 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jabbate19 commented Jan 25, 2025 •

edited

Loading