fix: use rand_chacha for random string generation#777
Merged
flemingcaleb merged 4 commits intomainfrom Jun 29, 2024
Merged
Conversation
flemingcaleb
added
bug
…and_chachachacha20rng
hulto
approved these changes
Jun 21, 2024
Cictrone
approved these changes
Jun 21, 2024
flemingcaleb
deleted the
774-bug-randomstring-function-does-not-use-rand_chachachacha20rng
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
updates random.string to use chacha_rng instead of the built-in thread_rng
Which issue(s) this PR fixes:
Fixes #774