Conversation
hulto
commented
Jul 11, 2024
Collaborator
Author
Hasn't been an issue the last four commits. |
KCarretto
reviewed
Dec 30, 2024
Cictrone
requested changes
Jan 31, 2025
Collaborator
Cictrone
left a comment
Cictrone
left a comment
There was a problem hiding this comment.
Reviewed rust code. Golang will come later.
| if !buf.has_remaining_mut() { | ||
| // Can't add to the buffer. | ||
| #[cfg(debug_assertions)] | ||
| log::debug!("DANGER can't add to the buffer."); |
Collaborator
There was a problem hiding this comment.
continue anyway? maybe add to the comment how this alters behavior
Collaborator
Author
There was a problem hiding this comment.
I don't think we want to exit here and manually draining the buffer doesn't seem safe.
Collaborator
Author
|
Server is crashing on calls to unmarshall. |
Adds a new test to ensure that the `key_history` LRU cache does not grow beyond its specified size limit of 1024 entries. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
REALM_tavern_encryption_private_keyTODO
env!Which issue(s) this PR fixes: