Conversation
jabbate19
force-pushed
the
creds-page
branch
from
646f863 to
81131e7
Compare
Collaborator
Author
Updated with grouping
|
cmp5987
previously approved these changes
Jan 25, 2025
Collaborator
cmp5987
left a comment
cmp5987
left a comment
There was a problem hiding this comment.
Some starting comments but this looks good so far.
tavern/internal/www/src/pages/host-details/components/HostStatistics.tsx
Outdated
Show resolved
Hide resolved
tavern/internal/www/src/pages/host-details/components/CredentialTable.tsx
Outdated
Show resolved
Hide resolved
tavern/internal/www/src/pages/host-details/components/CredentialTable.tsx
Show resolved
Hide resolved
Collaborator
Author
|
Solves #839 |
Collaborator
Author
|
Collaborator
|
@cmp5987 will let you review this one |
cmp5987
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a page to see credentials happed to a host. Currently you can only see them in GraphQL.
Example photos:
Which issue(s) this PR fixes: