Skip to content

Add GraphQL Mutation to Create Credentials for Host#808

Merged
jabbate19 merged 7 commits intomainfrom
graphql-create-credential
Jan 10, 2025
Merged

Add GraphQL Mutation to Create Credentials for Host#808
jabbate19 merged 7 commits intomainfrom
graphql-create-credential

Conversation

@jabbate19
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

If we have external tools that can provide us credentials, there is currently no easy way for those to be inserted.

  • Credentials no longer require a Task.
  • Credentials can be created via mutation

Which issue(s) this PR fixes:

:shipit:

@jabbate19 jabbate19 force-pushed the graphql-create-credential branch from 7de2327 to cd53dac Compare December 28, 2024 18:44
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to:

  • Implement generated the generated mutation resolver method in tavern/internal/graphql/mutation.resolvers.go ?
  • write a unit test for your new mutation by defining YAML test cases in a new

@jabbate19
Copy link
Copy Markdown
Collaborator Author

Do you need to:

  • Implement generated the generated mutation resolver method in tavern/internal/graphql/mutation.resolvers.go ?
  • write a unit test for your new mutation by defining YAML test cases in a new

@hulto Fixed!

@jabbate19 jabbate19 requested a review from hulto January 6, 2025 23:56
hulto
hulto previously approved these changes Jan 7, 2025
Copy link
Copy Markdown
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jabbate19 jabbate19 merged commit 1375eab into main Jan 10, 2025
@jabbate19 jabbate19 deleted the graphql-create-credential branch January 10, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants