Skip to content

[Tavern] golang.org/x/net v0.22.0 --> v0.33.0#811

Merged
hulto merged 1 commit intomainfrom
upgrade-net/http2
Jan 4, 2025
Merged

[Tavern] golang.org/x/net v0.22.0 --> v0.33.0#811
hulto merged 1 commit intomainfrom
upgrade-net/http2

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Upgrades our version of golang.org/x/net to v0.33.0, which includes support for the SETTINGS_ENABLE_CONNECT_PROTOCOL flag in the HTTP2 settings frame, which will hopefully enable websockets over http2 with GCP loadbalancers per RFC8441:

Upon receipt of SETTINGS_ENABLE_CONNECT_PROTOCOL with a value of 1, a
client MAY use the Extended CONNECT as defined in this document when
creating new streams. Receipt of this parameter by a server does not
have any impact.

More context: https://github.com/golang/net/pull/221/files#diff-87494b81b5b867765b07e19a5554cf86a4107dee34c192f86d1263e873d20018R54

Which issue(s) this PR fixes:

Fixes #726

@KCarretto KCarretto requested a review from hulto January 4, 2025 18:32
@hulto hulto merged commit 4149ba7 into main Jan 4, 2025
@hulto hulto deleted the upgrade-net/http2 branch January 4, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Reverse Shell (Beta) Broken in GCP

2 participants