Skip to content

[Tavern] Add EnvBool and Update Default Config#850

Merged
KCarretto merged 2 commits intomainfrom
env-bool
Feb 1, 2025
Merged

[Tavern] Add EnvBool and Update Default Config#850
KCarretto merged 2 commits intomainfrom
env-bool

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Adds EnvBool to represent boolean values
  • Updates how we log unset environment variables to a uniform style warning that configuration is missing
  • Makes the default logger use text output (via ENABLE_JSON_LOGGING)
    • Updated terraform to enable this by default
  • Defaults to excluding the tavern instance id from logs (via ENABLE_INSTANCE_ID_LOGGING)
    • Updated terraform to enable this by default
  • Allows graphql raw query logging (via ENABLE_GRAPHQL_RAW_QUERY_LOGGING)
    • Updated terraform to enable this by default
  • Adds EnvBool testing

@KCarretto KCarretto requested review from Cictrone and hulto February 1, 2025 07:33
@KCarretto KCarretto added this to the v0.2.0 milestone Feb 1, 2025
Copy link
Copy Markdown
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up and then your gucci

Comment thread tavern/config.go
@KCarretto KCarretto merged commit 1b2e358 into main Feb 1, 2025
@KCarretto KCarretto deleted the env-bool branch February 1, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants