Skip to content

fix(admin): Add admin navigation and access gate#858

Merged
cmp5987 merged 1 commit intomainfrom
cp-fix-management-view
Feb 4, 2025
Merged

fix(admin): Add admin navigation and access gate#858
cmp5987 merged 1 commit intomainfrom
cp-fix-management-view

Conversation

@cmp5987
Copy link
Copy Markdown
Collaborator

@cmp5987 cmp5987 commented Feb 3, 2025

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

There was an issue with the rebase for Admin view that lead to the Admin navigation items getting removed.

  • This PR adds the 'admin' view to the navigation
  • Moves logic for 'checking' loading/error state to the AccessGate
  • Moves logic for 'checking' admin status to a newly created 'AdminAccessGate'
  • Adds a 'sm' size styling for Buttons and hover states for 'outline' buttons
  • Moves 'PageWrapper' to 'features' as it now has a useHook and several components (cleanup).
Screenshot 2025-02-03 at 5 47 03 PM

@cmp5987 cmp5987 added cleanup Code cleanup and tech debt removal Frontend bug Something isn't working labels Feb 3, 2025
@cmp5987 cmp5987 merged commit ec74433 into main Feb 4, 2025
@cmp5987 cmp5987 deleted the cp-fix-management-view branch February 4, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup Code cleanup and tech debt removal Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants