Adding agent.eval that takes in arbitrary eldritch and executes it#916
Merged
Adding agent.eval that takes in arbitrary eldritch and executes it#916
agent.eval that takes in arbitrary eldritch and executes it#916Conversation
Collaborator
|
Woah!!!! 🤯 |
KCarretto
requested changes
May 1, 2025
Collaborator
KCarretto
left a comment
KCarretto
left a comment
There was a problem hiding this comment.
close but not quite :)
KCarretto
approved these changes
May 1, 2025
| let expected_output = String::from("hi\n"); | ||
| assert!( | ||
| r.text == expected_output, | ||
| "'{}' did not equal '{}'", |
Collaborator
There was a problem hiding this comment.
nit: Should use want: got: style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind documentation
/kind feature
/kind eldritch-function
Need to write docs also :/
Idea is that the new
agentmodule can be used for various meta-actions with the bot.