Skip to content

[Fix] go run tavern work by default #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 4 commits into from
Nov 8, 2025
Merged

[Fix] go run tavern work by default #978

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03d3c60
fix go run tavern
KCarretto Nov 8, 2025
cf62a1c
change default secret path
KCarretto Nov 8, 2025
c761469
back to temp?
KCarretto Nov 8, 2025
a4583a9
Add error level warning
KCarretto Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions tavern/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,21 +369,24 @@ func GetPubKey() (*ecdh.PublicKey, error) {
return pub, nil
}

func newSecretsManager() (secrets.SecretsManager, error) {
if EnvGCPProjectID.String() == "" && EnvSecretsManagerPath.String() == "" {
slog.Error("No configuration provided for secret manager path, using a potentially insecure default.")
return secrets.NewDebugFileSecrets("/tmp/tavern-secrets")
}
if EnvSecretsManagerPath.String() == "" {
return secrets.NewGcp(EnvGCPProjectID.String())
}

return secrets.NewDebugFileSecrets(EnvSecretsManagerPath.String())
}

func getKeyPair() (*ecdh.PublicKey, *ecdh.PrivateKey, error) {
curve := ecdh.X25519()

var secretsManager secrets.SecretsManager
var err error

if EnvSecretsManagerPath.String() == "" {
secretsManager, err = secrets.NewGcp("")
} else {
secretsManager, err = secrets.NewDebugFileSecrets(EnvSecretsManagerPath.String())
}
if err != nil {
slog.Error("unable to setup secrets manager")
slog.Error("if you're running locally try setting `export SECRETS_FILE_PATH='/tmp/secrets'` \n")
return nil, nil, fmt.Errorf("unable to connect to secrets manager: %s", err.Error())
secretsManager, err := newSecretsManager()
if err != nil || secretsManager == nil {
return nil, nil, fmt.Errorf("failed to configure secret manager: %w", err)
}

// Check if we already have a key
Expand Down
Loading