Add ability to skip compilation using PEP517 config settings#9
Conversation
|
I was just wondering -- how is the libsecp .so/.dll installed/found in your use case? Do you ask users to
What's the upside of also distributing a wheel for it? The downside is that it's one more package to cross-check hashes for, that could be used to hide a backdoor in. |
|
Yes, we ask users to install via apt or whatever is the preferred method for their system (e.g. see here) As for the upside of distributing wheel, faster build times But don't merge this yet, I am having troubles passing this in my app, working on a workaround... |
|
Okay, it finally worked P.S. As another thing I noticed for both electrum-ecc and electrum-aionostr, setuptools is complaining View warning log |
|
Ok. 2377ea2 looks good. |
2377ea2 to
b134e00
Compare
|
Rebased and squashed |
I saw you signed your git commits. I try not to invalidate commit signatures. |
|
Thanks. |
Using env vars usually works fine, but when including electrum (so it pulls electrum-ecc) as a dependency, because on PyPI wheels aren't uploaded, it is not convenient to ask users to set this env var each time they install the project
This allows to install the package via
pip install electrum-ecc -C electrum_ecc.dont_compile=trueOr in my case when I am using uv, I can just write in pyproject.toml:
P.S. While I understand why this package may have wheels not uploaded, why does
electrum-aionostrhave no uploaded wheels if they should be universal like py3-any?