Made first letter of default toggle flag usage lowercase according to cobra conventions.#110
Made first letter of default toggle flag usage lowercase according to cobra conventions.#110junglehornet wants to merge 2 commits intospf13:mainfrom
Conversation
… cobra convention
|
|
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
Aha! Now I see why you opened that other PR 😁. Thanks for this.
Could you look into the CI failure?
| // Cobra also supports local flags, which will only run | ||
| // when this action is called directly. | ||
| rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle") | ||
| rootCmd.Flags().BoolP("toggle", "t", false, "help message for toggle") |
There was a problem hiding this comment.
I believe there’s another one below at line 160. Might as well fix that one too.
There was a problem hiding this comment.
Sure, I'll look into those when I have some more time.
…according to cobra convention
|
The other one on line 160 has been fixed. I'll start looking into the checks once you run the workflows again. |
|
Looks like the latest commit to the main branch of cobra-cli that I forked from failed all of the same checks, so it wasn't something that I did, and I'm not sure how to fix all of them. |
I'll have to look into it. |
3 participants
The first letter in the default help message for the toggle flag was uppercase, so I made it lowercase according to cobra convention.