Bump to 2023 year in testdata#64
Bump to 2023 year in testdata#64ivankovnatsky wants to merge 1 commit intospf13:mainfrom ivankovnatsky:main
Conversation
|
CI is failing fort other reasons. Sigh... |
|
Can this be fixed permanently with |
I agree we need a better approach. However allowing the tests to pass would prevent user from remembering these files need to be changed. But I haven't looked at the code in a while so I might be missing something. |
|
Such a failure sounds suitable for your CI (upstream), but I think basically anyone else will be unhappy with that breakage. There are situations when even older versions are desirable to use (e.g. bisecting regressions across history) and then similar newly-appearing failures can be annoying. |
|
Damn it, I was cleaning up some public forked repos. |
|
This PR is being marked as stale due to a long period of inactivity |
jpmcb
left a comment
There was a problem hiding this comment.
Let's ship this, get tests passing, and open a new issue to revisit this.
I just ran into this as well and it's annoying to have test flakes while working on other things.
Close #63.