Skip to content

Persistent flags completions#180

Closed
fabianofranz wants to merge 2 commits into
spf13:masterfrom
fabianofranz:persistent_flags_completions
Closed

Persistent flags completions#180
fabianofranz wants to merge 2 commits into
spf13:masterfrom
fabianofranz:persistent_flags_completions

Conversation

@fabianofranz
Copy link
Copy Markdown
Contributor

Inherited flags should also be part of completions for every command that inherits it. Also allows marking persistent flags as required or filename for completions.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have accepted the CLA.

@fabianofranz
Copy link
Copy Markdown
Contributor Author

@eparis PTAL

@eparis
Copy link
Copy Markdown
Collaborator

eparis commented Nov 4, 2015

gimmie some _test.go. But it seems ok/good/right

@fabianofranz fabianofranz force-pushed the persistent_flags_completions branch from 73ffc8b to a4ca610 Compare November 4, 2015 20:08
@fabianofranz
Copy link
Copy Markdown
Contributor Author

@eparis added some.

@fabianofranz
Copy link
Copy Markdown
Contributor Author

@eparis circleci failure seems unrelated.

@spf13
Copy link
Copy Markdown
Owner

spf13 commented Nov 6, 2015

merged as 7290a94.

Yes, circle is unrelated and I've already contacted them about it.

@spf13 spf13 closed this Nov 6, 2015
@anthonyfok
Copy link
Copy Markdown
Collaborator

The CircleCI failure seems to be the same as Travis CI build failure:

=== RUN TestRunnableRootCommandNilInput-2
--- FAIL: TestRunnableRootCommandNilInput-2 (0.00s)
    cobra_test.go:667: Execute() failed with unknown shorthand flag: 't' in -test.v=true
    cobra_test.go:671: Root Function was not called

It is triggered by the use of -v flag for go test. Please see #155 for a potential solution.

@anthonyfok
Copy link
Copy Markdown
Collaborator

Forgot to say: @fabianofranz, this is awesome! :-) Now bash completion for Hugo works quite a bit better indeed, e.g. the --watch in hugo server --watch can now be tab-completed. :-)
Many thanks!

@fabianofranz
Copy link
Copy Markdown
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants