fixes verbose tests by checking if the first arg belongs to cobra#182
Merged
Conversation
Owner
|
pushed as 62e859a |
Collaborator
|
Hi @spf13, Sorry for my earlier premature recommendation for the fix. It turns out that this patch has undesirable side-effects: Specifying full path to the executable, or renaming the executable, would make it ignore any command-line arguments. Using All subcommands and flags are ignored... I discovered this problem when trying to @apriendeau, any ideas of an alternative solution? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the tests by checking if first arg is the same as the name as the root command in cobra. Replaces PR #155 @eparis @spf13 @anthonyfok