Add golangci-lint and GitHub Actions workflow by umarcor · Pull Request #968 · spf13/cobra

umarcor · 2019-10-02T19:49:49Z

Close #952

In this PR~~, Travis CI and CircleCI are deprecated in favour of~~ a GitHub Actions workflow is added:

As proposed in GitHub Actions #952, GNU/Linux (ubuntu-latest), Windows and macOs platforms are tested.
Regarding golang versions, the proposed matrix includes 1.10.x, 1.11.x, 1.12.x, 1.13.x and 1.14.x.
Compared to the current Travis matrix, 1.10.x, 1.11.x and tip are removed and 1.13.x and 1.14.x are added. Note that tip is not supported in GitHub Actions by default yet (Support tip? actions/setup-go#21).

~~Execution example: https://github.com/dbhi/cobra/commit/9bdf771ff8e6f415a56446759031a9864e4d6c50/checks?check_suite_id=248869625~~

jharshman · 2019-10-04T20:53:10Z

@umarcor I would want to run these side by side with TravisCI and CircleCI to evaluate.

umarcor · 2019-10-04T21:20:30Z

@umarcor I would want to run these side by side with TravisCI and CircleCI to evaluate.

I reverted removing the corresponding configuration files. For the GHA test to show here, some dummy workflow needs to exist in the master branch of cobra.

https://github.com/dbhi/cobra/commit/66d6f7314903ce18a459c9d2f9b1aaac7fbf1c24/checks?check_suite_id=252259674

umarcor · 2019-12-23T12:19:31Z

Request to be included in 1.0.0. Ref #959.

umarcor · 2020-04-13T16:13:26Z

@jharshman, any chance of getting this merged? It would provide CI to any GitHub user, without requiring them to setup external services.

jharshman · 2020-04-13T17:48:23Z

#952 (comment)

Our current experimentation with Github Actions haven't actually worked so far. So you see where I am reluctant to adopt this further.

umarcor · 2020-04-13T18:06:03Z

As explained in #952 (comment), this PR is harmless, unlike #1074 and #1075.

jharshman · 2020-04-13T18:31:09Z

#952 (comment)

#1074 and #1075 do make permanent modifications in the repo
No these were less than low impact and do not make any permanent modifications or changes.

@umarcor I am all for using GH actions, but as of right now - I am not sold on the direction or utility. However, the other maintainers and myself will discuss it in planning.

umarcor · 2020-05-11T11:19:07Z

@jharshman, any update?

FTR, exec time on GHA is ~2m, on Travis it's ~7min.

umarcor · 2020-05-11T11:37:02Z

For the GHA test to show here, some dummy workflow needs to exist in the master branch of cobra.

This is not required any more. Since some action workflow (the labeler) existed for some weeks, workflows contributed by PRs are now executed and shown both here and in https://github.com/spf13/cobra/actions.

Hence, users willing to use GHA can cherry-pick the commit in this PR, regardless of the maintainers picking it.

)

umarcor · 2020-12-04T23:42:01Z

Since Travis CI scaled down and limited the resources for free open source accounts, CI runs take up to 3h to execute: https://travis-ci.org/github/spf13?tab=insights. This is not specific to this repo, but applies to many other projects.

At the samme time, this PR has been working successfully for over a year now. The execution time of the longest test is 4m. Moreover, no breaking change is introduced, and golang-ci is added.

Therefore, I'd like to ask maintainers to please make a decision. Either let me know what changes you expect, or please close this issue. Ref: #952 (comment).

/cc @jharshman @wfernandes @jpmcb

)

* field 'tc' * 'isEmpty', 'executeTemplate', 'writeStringToFile', 'update' and 'checkLackFiles' * 'writeToFile', 'commentifyString', 'stringInStringSlice' and 'exists'

umarcor · 2021-01-30T03:42:31Z

Closed in favour of #1044.

umarcor force-pushed the actions branch from e3fa647 to 9bdf771 Compare October 2, 2019 22:11

umarcor force-pushed the actions branch from 9bdf771 to 66d6f73 Compare October 4, 2019 21:19

umarcor mentioned this pull request Oct 9, 2019

Add Makefile to project #976

Merged

umarcor force-pushed the actions branch from 66d6f73 to 1e099f7 Compare October 14, 2019 12:24

umarcor marked this pull request as ready for review December 23, 2019 12:19

umarcor force-pushed the actions branch 2 times, most recently from a942682 to 1943240 Compare January 4, 2020 17:55

umarcor changed the title ~~migrate from Travis CI and CircleCI to GitHub Actions~~ Add GitHub Actions workflow Jan 4, 2020

umarcor force-pushed the actions branch from 1943240 to 53471d1 Compare January 6, 2020 18:25

umarcor force-pushed the actions branch from 53471d1 to c11c9d5 Compare February 20, 2020 22:04

umarcor mentioned this pull request Feb 20, 2020

chore(ci): add release note generation #1040

Closed

umarcor force-pushed the actions branch from c11c9d5 to d8797cb Compare March 1, 2020 01:35

umarcor force-pushed the actions branch from d8797cb to 96e8615 Compare April 13, 2020 16:11

This was referenced Apr 13, 2020

GitHub Actions #952

Closed

env variable available for git outh key #1089

Closed

umarcor force-pushed the actions branch from 96e8615 to 8c45bd5 Compare May 11, 2020 11:13

umarcor force-pushed the actions branch from 8c45bd5 to 385666a Compare May 11, 2020 14:15

umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020

ci: add GitHub Actions workflow 'push' (spf13#968)

cd9b3a7

umarcor mentioned this pull request May 11, 2020

v1.1.0rc #1028

Closed

umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020

ci: add GitHub Actions workflow 'push' (spf13#968)

62d881d

umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020

ci: add GitHub Actions workflow 'push' (spf13#968)

f60e06e

umarcor force-pushed the actions branch 2 times, most recently from 785a9c1 to 298c1c4 Compare September 25, 2020 12:48

umarcor added a commit to umarcor/cobra that referenced this pull request Sep 25, 2020

use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044

72c92fb

)

umarcor mentioned this pull request Sep 25, 2020

Cobra User Contract (Draft) #1232

Closed

umarcor force-pushed the actions branch from 298c1c4 to 05cd0f0 Compare October 1, 2020 17:07

umarcor added a commit to umarcor/cobra that referenced this pull request Oct 1, 2020

use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044

f9ea39e

)

umarcor force-pushed the actions branch from 05cd0f0 to a3b3f22 Compare October 14, 2020 18:55

umarcor added a commit to umarcor/cobra that referenced this pull request Oct 14, 2020

use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044

dc9bed2

)

umarcor force-pushed the actions branch from a3b3f22 to 042d8a8 Compare October 18, 2020 20:09

umarcor added a commit to umarcor/cobra that referenced this pull request Oct 18, 2020

use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044

eab7ed2

)

umarcor force-pushed the actions branch from 042d8a8 to 9de1b05 Compare November 14, 2020 12:33

umarcor force-pushed the actions branch from 9de1b05 to 3ce3531 Compare December 4, 2020 23:27

umarcor added a commit to umarcor/cobra that referenced this pull request Dec 4, 2020

use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044

932b1eb

)

umarcor added 11 commits December 29, 2020 17:38

add .gitattributes

ef5574e

ci: use golangci-lint and add GitHub Actions workflow 'push'

645f182

use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...))

e0ae253

reduce size of struct

111c42c

make 'one two' a constant

d8fd21d

remove dead (unused) code

cfb9cc8

* field 'tc' * 'isEmpty', 'executeTemplate', 'writeStringToFile', 'update' and 'checkLackFiles' * 'writeToFile', 'commentifyString', 'stringInStringSlice' and 'exists'

make string ''\)\n' a constant

4a65678

print to stderr in boilerplate (spf13#774)

13ac70f

style(command_test)

c9c3c56

fix gosec G204

df7929d

add 'CheckErr' and 'assertNoErr'

f3a7c61

umarcor force-pushed the actions branch from 3ce3531 to f3a7c61 Compare December 29, 2020 16:40

umarcor closed this Jan 30, 2021

umarcor deleted the actions branch January 30, 2021 03:43

umarcor mentioned this pull request Feb 8, 2021

ci: add GitHub Actions workflow 'Test' #1339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add golangci-lint and GitHub Actions workflow#968

Add golangci-lint and GitHub Actions workflow#968
umarcor wants to merge 11 commits into
spf13:masterfrom
umarcor:actions

umarcor commented Oct 2, 2019 •

edited

Loading

Uh oh!

jharshman commented Oct 4, 2019

Uh oh!

umarcor commented Oct 4, 2019 •

edited

Loading

Uh oh!

umarcor commented Dec 23, 2019

Uh oh!

umarcor commented Apr 13, 2020

Uh oh!

jharshman commented Apr 13, 2020 •

edited

Loading

Uh oh!

umarcor commented Apr 13, 2020

Uh oh!

jharshman commented Apr 13, 2020

Uh oh!

umarcor commented May 11, 2020 •

edited

Loading

Uh oh!

umarcor commented May 11, 2020

Uh oh!

umarcor commented Dec 4, 2020 •

edited

Loading

Uh oh!

umarcor commented Jan 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

umarcor commented Oct 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jharshman commented Oct 4, 2019

Uh oh!

umarcor commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umarcor commented Dec 23, 2019

Uh oh!

umarcor commented Apr 13, 2020

Uh oh!

jharshman commented Apr 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umarcor commented Apr 13, 2020

Uh oh!

jharshman commented Apr 13, 2020

Uh oh!

umarcor commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umarcor commented May 11, 2020

Uh oh!

umarcor commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umarcor commented Jan 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

umarcor commented Oct 2, 2019 •

edited

Loading

umarcor commented Oct 4, 2019 •

edited

Loading

jharshman commented Apr 13, 2020 •

edited

Loading

umarcor commented May 11, 2020 •

edited

Loading

umarcor commented Dec 4, 2020 •

edited

Loading