Skip to content

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jun 28, 2024

See https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel,
this allows third-party extensions to set this attribute on the node and have it propagate to the output HTML,
for example executablebooks/MyST-Parser#857

related to #12477
(see also https://www.freecodecamp.org/news/what-is-tabnabbing/, for why it should be used when opening links in new tabs)

See https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel,
this allows third-party extensions to set this attribute on the node and have it propagate to the output HTML,
for example executablebooks/MyST-Parser#857
@chrisjsewell chrisjsewell requested a review from jayaddison June 28, 2024 10:46
@jayaddison
Copy link
Contributor

Seems good in terms of feature-consistency to provide rel alongside target on these nodes. Is there somewhere we could add test coverage for both of these?

@chrisjsewell
Copy link
Member Author

Is there somewhere we could add test coverage for both of these?

this a pain, because there is no built-in functionality to add these attributes, but feel free to add one in a follw-up

@chrisjsewell chrisjsewell merged commit 8387f4a into master Jul 3, 2024
@chrisjsewell chrisjsewell deleted the chrisjsewell-patch-1 branch July 3, 2024 10:53
@jayaddison
Copy link
Contributor

Ok, no problem, that seems OK as an exception -- thanks @chrisjsewell

@AA-Turner AA-Turner added this to the 7.4.0 milestone Jul 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants