Turn show_warning_types on by default#12597
Merged
AA-Turner merged 5 commits intoJul 20, 2024
Merged
Conversation
Member
|
I'm not sure about this one. It might break automated tools that parse the output of the log depending on how they parse it. Maybe for 8.x but this is a breaking change IMO. What you can however do is change the default project template or at least, put it in comment so that users know about this feature. (Personally, I don't mind, but I don't want to break things (but maybe for 8.x?)) |
Member
Author
Yep, that's why I opened it now after the minor release |
Closed
AA-Turner
approved these changes
Jul 20, 2024
AA-Turner
changed the title
show_warning_types default to Trueshow_warning_types on by default
Member
Author
|
Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #12131 I added the
show_warning_types, to show the warning type/subtype.As I explained there, I think this is very helpful for helping users understand the source of the warning and understand how to suppress it if desired,
and also it is inline with the tools in the Python ecosystem (mypy, ruff, pylint, ...)
As per python/mypy#13542, here I am advocating for making this on by default.
I feel that although it was a good step to add the functionality, still most users will not realise it is possible and there is no real downside to having this on by default