Add 'ignorable' flag to import mappings#570
Merged
Conversation
The new flag works analogously to export mappings: it makes the mapping to process child mappings even when the imported value is None. Otherwise we skip the children. Re spine-tools/Spine-Toolbox#3165
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 84.49% 84.96% +0.47%
==========================================
Files 80 80
Lines 10889 10931 +42
Branches 1599 1600 +1
==========================================
+ Hits 9201 9288 +87
+ Misses 1322 1280 -42
+ Partials 366 363 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soininen
deleted the
toolbox_3165_fix_missing_entity_alternative_import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new flag works analogously to export mappings: if
True, child mappings will get processed even when the imported value is None. Otherwise we skip the children.Fixes spine-tools/Spine-Toolbox#3165
Checklist before merging