Correctly avoid using ostruct
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work:
$ ruby -e 'Struct.new(:foo => "bar")'
-e:1:in 'Struct.new': unknown keyword: :foo (ArgumentError)
from -e:1:in '<main>'
This reverts commit 1b5f994.
The OpenStruct library was not used in that test. ostruct raises a warning about not being a shipped-and-bundled-with-Ruby standard library in Ruby 3.5.0.
...in order to avoid Ruby warnings in Ruby 3.5.0 about ostruct not being a built-in library.
Member
Author
|
I hope you don't mind @olleolleolle |
dentarg
referenced
this pull request
Feb 13, 2025
> warning: ostruct was loaded from the standard library, but will no > longer be part of the default gems starting from Ruby 3.5.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as it no longer will ship with Ruby 3.5
From ddollar#807
Credits to @olleolleolle