Open
Conversation
This protects Spin from allocating an arbitrarily large amount of memory to buffer an incoming query result. I plan to do the same for other database factors and spin outbound HTTP in later commits. Note that I've copied tests/runtime-tests/tests from https://github.com/fermyon/conformance-tests/tree/main/tests/sqlite since otherwise tests/test-components/components/sqlite would not be run.
This builds on the corresponding PR for `factor-sqlite` and refactors that a bit to minimize redundancy.
This builds on the corresponding PRs for `factor-sqlite` and `factor-outbound-pg`.
This builds on the corresponding PRs for `factor-sqlite`, and `factor-outbound-pg`, and `factor-outbound-mysql`.
This builds on the corresponding PRs for `factor-sqlite`, and `factor-outbound-pg`, `factor-outbound-mysql`, and `factor-key-value`.
This builds on the corresponding PRs for `factor-sqlite`, and `factor-outbound-pg`, `factor-outbound-mysql`, `factor-key-value`, and `factor-llm`.
This builds on the corresponding PRs for `factor-sqlite`, and `factor-outbound-pg`, `factor-outbound-mysql`, `factor-key-value`, `factor-llm`, and `factor-outbound-http`. Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
limit-result-sizes
branch
from
2f92985 to
f80db21
Compare
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits buffered response sizes across various factors: sqlite, outbound-pg, outbound-mysql, key-value, llm, outbound-http.