Merged
Conversation
lann
force-pushed
the
remove-wagi-dependency
branch
2 times, most recently
from
2820e8c to
1c9cb2e
Compare
Merged
lann
force-pushed
the
remove-wagi-dependency
branch
from
1c9cb2e to
6e003e2
Compare
radu-matei
approved these changes
Aug 24, 2022
Spin's Wagi implementation depended on only a few functions from the 'wagi' crate. Remove the crate dependency by copying those functions into Spin, with some small adaptations. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
remove-wagi-dependency
branch
from
6e003e2 to
faf2964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spin's Wagi implementation depended on only a few functions from the
'wagi' crate. Remove the crate dependency by copying those functions into
Spin, with some small adaptations.
This removes some transitive dependencies including
wasi-experimental-http.