Skip to content

Fix/call finalizers in fakehttp#87

Merged
roxblnfk merged 2 commits intospiral:2.xfrom
chiost:fix/call-finalizers-in-fakehttp
Feb 3, 2026
Merged

Fix/call finalizers in fakehttp#87
roxblnfk merged 2 commits intospiral:2.xfrom
chiost:fix/call-finalizers-in-fakehttp

Conversation

@chiost
Copy link
Contributor

@chiost chiost commented Feb 3, 2026

What was changed

FakeHttp::handleRequest() now calls FinalizerInterface::finalize(false) after each request, matching the behavior of RoadRunner HTTP Dispatcher.

Why?

Without calling finalizers, state leaks between sequential HTTP requests in tests. For example, Cycle ORM
heap is not cleaned between requests (cleanup is registered in CycleOrmBootloader), causing entities cached
in memory to mask persistence bugs.

Checklist

@roxblnfk roxblnfk merged commit 3942b4d into spiral:2.x Feb 3, 2026
10 of 11 checks passed
@roxblnfk roxblnfk mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fakeHttp() should call FinalizerInterface after each request

2 participants