Clubhouse-148415: Tweaking the mapping of complex type to support setting to blank#9
Merged
jfbramlett merged 1 commit intomasterfrom Aug 18, 2021
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #148415: Reloading an existing model does not update timestamp fields. |
alexbednarczyk
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading values from the DB into an existing object if that object has an existing value and the DB value is nil this was not "resetting" the value, this will set the value to nil if it can (otherwise relies on the Decode to respect the fact the DB might not provide a value).
We were seeing this issue after blanking a Publish_At time on a model.
See Clubhouse-148415 for more details.