Merged
Conversation
Semver release
Release 4.12.1: fixed deadlock for VirtualThread
sanzmauro
reviewed
Aug 13, 2024
nmayorsplit
reviewed
Aug 13, 2024
Contributor
nmayorsplit
left a comment
nmayorsplit
left a comment
There was a problem hiding this comment.
There are some things to update.
gthea
reviewed
Aug 13, 2024
sanzmauro
requested changes
Aug 14, 2024
Contributor
sanzmauro
left a comment
sanzmauro
left a comment
There was a problem hiding this comment.
You have 7 code smells. Please try to fix them before merge 🙏
Have you already reviewed them?
Contributor
Author
I reviewed and fixed all except one, cannot use try-with-reference since the variable InputStreamReader cannot be final. |
sanzmauro
approved these changes
Aug 14, 2024
|
SonarQube Quality Gate
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.